-
-
Notifications
You must be signed in to change notification settings - Fork 638
Concurrently drain streaming fibers #2015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ihabadham
wants to merge
39
commits into
master
Choose a base branch
from
concurrently-drain-streaming-fibers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+344
−20
Open
Changes from 35 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
eac0c28
add concurrent_stream_drain flag (default false)
ihabadham 03da5bf
add and bundle async runtime dependency
ihabadham 343fd4b
concurrent fiber draining via Async with single writer; add tracing l…
ihabadham 49e73e2
make sequential draining robust to already finished fibers
ihabadham b285d38
add default backpressure via Async::Semaphore and handle client disco…
ihabadham 355157a
add controller streaming specs for sequential vs concurrent, ordering…
ihabadham 7767cdc
add a test for backpressure
ihabadham 0c493b4
refactor to correct rubocop offenses
ihabadham fd36e2d
fix NoMethodError caused by Array.bytesize
ihabadham 23c8cd5
add concurrent_stream_queue_capacity (default 64) and use it in strea…
ihabadham 57a617d
add a comment explaining why semaphore.acquire is preferable to semap…
ihabadham 54fdf01
refactor(stream): use Async::Queue#close as a final single sentinel; …
ihabadham 25c0ae2
refactor: propagate streaming errors instead of rescuing
ihabadham c70d8b3
ci: correct rubocop offenses
ihabadham ae61932
add a simpler test for the concurrent stream_view_containing_react_co…
AbanoubGhadban 85cb20c
refactor streaming tests to use pure mock approach
ihabadham be5f5dd
DRY the tests
ihabadham b6479c1
remove the concurrent_stream_drain config flag and always stream comp…
ihabadham f5f0f5a
remove debug logging
ihabadham bf320b6
correct rubocop offenses
ihabadham a7ed3cd
use async queue instead of ruby array at helper spec
AbanoubGhadban 23b7eca
Revert "use async queue instead of ruby array at helper spec"
AbanoubGhadban a00d522
Enhance helper spec to support Async::Queue for chunk processing
AbanoubGhadban f4b8b0e
Revert "Enhance helper spec to support Async::Queue for chunk process…
AbanoubGhadban 2e0c397
Refactor helper spec to utilize Async::Queue for improved chunk proce…
AbanoubGhadban dd5f321
Refactor configuration and streaming logic to use concurrent_componen…
AbanoubGhadban f9d493b
Refactor streaming logic to remove unnecessary error handling for imp…
AbanoubGhadban 6cd4f07
pass buffer_size to LimitedQueue as a positional argument because it …
ihabadham cd301bc
ci: correct rubocop offenses
ihabadham 7c8b9ad
ci: avoid getting a rubocop error
ihabadham 3e13f98
update CHANGELOG.md
ihabadham 91b203c
Update react_on_rails to 16.0.1.rc.4 to fix yanked version issue
ihabadham 11c59d9
remove accidently pushed Gemfile.local.backup
ihabadham 3bbc66f
git ignore .claude/
ihabadham f95d0f2
Fix ReactOnRails::PackerUtils.using_packer? compatibility with react_…
ihabadham a174d92
Remove redundant .claude/ entry from react_on_rails_pro/.gitignore
ihabadham de973fe
Add missing validation call for concurrent_component_streaming_buffer…
ihabadham 38377bc
Validate buffer size as Integer instead of Numeric
ihabadham e9dd3ee
Add test for client disconnect cleanup behavior
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -75,3 +75,5 @@ yalc.lock | |
|
|
||
| # React on Rails Pro License Key | ||
| config/react_on_rails_pro_license.key | ||
|
|
||
| .claude/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.