-
Notifications
You must be signed in to change notification settings - Fork 360
no_std support for all crates
#717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Could this PR be revisited, now that all the dependencies are merged? |
|
I think option 1 described above is feasible: We'll use Currently I'm waiting for Once these are done, we'll probably need to convince And finally, we'll need a new release with these changes. If you can get some traction on the linked PRs, then I'll be glad to give this some more work. |
|
☔ The latest upstream changes (presumably #728) made this pull request unmergeable. Please resolve the merge conflicts. |
Add default feature flag "std" that enables a `std::error::Error` impl for `Errors`.
|
What is the current state of this? It seems to have completely stalled, even though all the blockers seems to have been merged & resolved? |
|
It has stalled mainly because I haven't received word from the maintainers on neither this nor #722. In the meantime, a PR for changing the layout of the network primitives is almost merged, after that RFC 2832 should be fairly trivial to accept. A way forward once we get that is to use something like |
|
Wauw, that is awesome news! 👍 |
|
☔ The latest upstream changes (presumably #783) made this pull request unmergeable. Please resolve the merge conflicts. |
Fixes #609.
Our dependencies need to supportDone:no_stdmatches, support since version0.1.9, see Makematchescrateno_stdcompatible SimonSapin/rust-std-candidates#23unicode-bidi, support since version0.3.6, see Addno_stdsupport unicode-bidi#58unicode-normalization, support since version0.1.13, see Add no_std + alloc support unicode-rs/unicode-normalization#55As far as I can see there's a few ways to solve the
std::netissue noted in the linked issue:no-std-netonno_stdtargets. Since that library doesn't have a MSRV, we might need to define thatno_stdsupport doesn't guarantee a MSRV (until we find a more permanent solution).Hostto store custom ip address types, and returnstd::nettypes in functions (that can then be feature gated). Requires a breaking version.As far as I can see option 1 is possible now, and it could even (with a little more work on
no-std-netbeforehand) be possible to migrate away from once (if) the RFC is stabilized, all without breaking changes.