Skip to content

Conversation

@ssssota
Copy link

@ssssota ssssota commented Dec 27, 2024

close #51

The existing tests passed, but I am a beginner in this area, so I have not been able to fully verify the validity of the changes.

@ssssota

This comment was marked as outdated.

@ssssota

This comment was marked as outdated.

@ssssota

This comment was marked as outdated.

@ssssota

This comment was marked as outdated.

@ssssota ssssota marked this pull request as ready for review October 31, 2025 10:26
@jdm
Copy link
Member

jdm commented Oct 31, 2025

Do you have a Windows environment to test these changes? If so, can you try making a build of Servo that uses this branch and verify that it still loads pages and displays text?

@ssssota
Copy link
Author

ssssota commented Nov 1, 2025

@jdm
I tried to build Servoshell, but it won't work immediately because the PR includes a breaking change in the interface (Result<(), winapi::um::winnt::HRESULT> -> Result<(), windows_core::HRESULT>, etc.). To what extent should the interface be maintained?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

use windows crate instead of winapi

2 participants