[Fix #932] Workflow scheduler #966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjtirado
force-pushed
the
Fix_#932
branch
2 times, most recently
from
f76ecef to
304ffda
Compare
fjtirado
force-pushed
the
Fix_#932
branch
2 times, most recently
from
b6d40e0 to
2adb5a6
Compare
ricardozanini
approved these changes
Nov 7, 2025
impl/core/src/main/java/io/serverlessworkflow/impl/scheduler/CronResolverFactory.java
Outdated
Show resolved
Hide resolved
impl/core/src/main/java/io/serverlessworkflow/impl/scheduler/CronUtilsResolverFactory.java
Outdated
Show resolved
Hide resolved
impl/core/src/main/java/io/serverlessworkflow/impl/scheduler/DefaultWorkflowScheduler.java
Outdated
Show resolved
Hide resolved
| try (WorkflowDefinition def = | ||
| appl.workflowDefinition(readWorkflowFromClasspath("workflows-samples/cron-start.yaml"))) { | ||
| await() | ||
| .atMost(Duration.ofMinutes(1).plus(Duration.ofSeconds(10))) |
Collaborator
Author
There was a problem hiding this comment.
ah, its a picky thing, in case we test a different minute quantity (the minimum for unix cron), you always need to increase it a few seconds to give some margin, so you just need to change the minute quantity, not the second one
fjtirado
force-pushed
the
Fix_#932
branch
2 times, most recently
from
399ab50 to
e4b5acf
Compare
Signed-off-by: fjtirado <ftirados@redhat.com>
treblereel
pushed a commit
to treblereel/serverless-workflow-sdk-java
that referenced
this pull request
Nov 7, 2025
Signed-off-by: fjtirado <ftirados@redhat.com> Signed-off-by: Dmitrii Tikhomirov <chani.liet@gmail.com>
ricardozanini
added a commit
that referenced
this pull request
Nov 10, 2025
* [Fix #933] Adding timeout support (#963) Signed-off-by: fjtirado <ftirados@redhat.com> Signed-off-by: Dmitrii Tikhomirov <chani.liet@gmail.com> * [Fix #932] Workflow scheduler (#966) Signed-off-by: fjtirado <ftirados@redhat.com> Signed-off-by: Dmitrii Tikhomirov <chani.liet@gmail.com> * Add initial RunContainer Task support Signed-off-by: Dmitrii Tikhomirov <chani.liet@gmail.com> Signed-off-by: Dmitrii Tikhomirov <chani.liet@gmail.com> * image pull before run Signed-off-by: Dmitrii Tikhomirov <chani.liet@gmail.com> * refactoring + tests Signed-off-by: Dmitrii Tikhomirov <chani.liet@gmail.com> * Review comments Signed-off-by: fjtirado <ftirados@redhat.com> Signed-off-by: Dmitrii Tikhomirov <chani.liet@gmail.com> * Disable test if docker is not Signed-off-by: fjtirado <ftirados@redhat.com> Signed-off-by: Dmitrii Tikhomirov <chani.liet@gmail.com> * Update impl/container/pom.xml Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com> Signed-off-by: Dmitrii Tikhomirov <chani.liet@gmail.com> * post review Signed-off-by: Dmitrii Tikhomirov <chani.liet@gmail.com> * name docker check method Signed-off-by: Dmitrii Tikhomirov <chani.liet@gmail.com> --------- Signed-off-by: fjtirado <ftirados@redhat.com> Signed-off-by: Dmitrii Tikhomirov <chani.liet@gmail.com> Co-authored-by: Francisco Javier Tirado Sarti <65240126+fjtirado@users.noreply.github.com> Co-authored-by: fjtirado <ftirados@redhat.com> Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #932