Fix: update code to reflect 1.3 #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WDombrowski
approved these changes
Feb 5, 2024
m-mead
reviewed
Feb 6, 2024
| @@ -0,0 +1,260 @@ | |||
| #!/usr/bin/env python3 | |||
Collaborator
There was a problem hiding this comment.
It is out of the scope of this pull request, but I think it makes sense to consolidate the changes in this file into examples/seekcamera-opencv.py. The recording changes are helpful and don't overload the purpose of this file in my opinion.
m-mead
reviewed
Feb 6, 2024
m-mead
approved these changes
Feb 6, 2024
Collaborator
m-mead
left a comment
m-mead
left a comment
There was a problem hiding this comment.
Nice cleanup. I left two small comments but am approving this either way.
Signed-off-by: Todd Mullanix <tmullanix@thermal.com>
Signed-off-by: Todd Mullanix <tmullanix@thermal.com>
Signed-off-by: Todd Mullanix <tmullanix@thermal.com>
Signed-off-by: Todd Mullanix <tmullanix@thermal.com>
Signed-off-by: Todd Mullanix <tmullanix@thermal.com>
Signed-off-by: Todd Mullanix <tmullanix@thermal.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was out of date with the 1.3.0 zipfile. See #27