Skip to content

Conversation

@lwjohnst86
Copy link
Member

Description

I wanted to explain why we don't use validate, for any readers who are interested.

Closes #181

Needs an in-depth review.

Checklist

  • Formatted Markdown
  • Ran just run-all

Copy link
Contributor

@joelostblom joelostblom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but someone with more context needs to approve. One minor comment

Copy link
Member

@signekb signekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to include an explanation of this decision 👌

Could this be a lot shorter by cutting out the paragraphs comparing and explaning the difference between "validate" and "verify"? I'm not sure it's relevant now that we use "check". Couldn't the argument simply be that the word "validate" is used a lot of places in a way that doesn't align with what the word actually means, and therefore, we use the word "check" instead?

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Iteration planning Nov 17, 2025
lwjohnst86 and others added 2 commits November 18, 2025 09:24
Co-authored-by: Signe Kirk Brødbæk <signebroedbaek@gmail.com>
@lwjohnst86 lwjohnst86 moved this from In Progress to In Review in Iteration planning Nov 18, 2025
joelostblom
joelostblom previously approved these changes Nov 18, 2025
Copy link
Member

@signekb signekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 I still think this could be shorter (😬), but if you prefer to keep as is that's fine with me too.

I do have some minor suggestions again:

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Iteration planning Nov 18, 2025
@lwjohnst86
Copy link
Member Author

@signekb if you have suggestions to shorten it, please do give them! 😝

@signekb
Copy link
Member

signekb commented Nov 18, 2025

I'll give it a go when you've implemented the suggestions you prefer from my review 👍

Co-authored-by: Signe Kirk Brødbæk <signebroedbaek@gmail.com>
lwjohnst86 and others added 2 commits November 19, 2025 08:46
Co-authored-by: Signe Kirk Brødbæk <signebroedbaek@gmail.com>
@lwjohnst86 lwjohnst86 requested a review from signekb November 19, 2025 07:49
Copy link
Member

@signekb signekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alrighty. This might be controversial. Let me know what you think :)

Co-authored-by: Signe Kirk Brødbæk <signebroedbaek@gmail.com>
@lwjohnst86 lwjohnst86 requested a review from signekb November 19, 2025 14:57
@lwjohnst86 lwjohnst86 moved this from In Progress to In Review in Iteration planning Nov 19, 2025
joelostblom
joelostblom previously approved these changes Nov 20, 2025
Copy link
Contributor

@joelostblom joelostblom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read well to me!

Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com>
@lwjohnst86
Copy link
Member Author

@joelostblom just fyi, when you approve, don't include a comment change if you have no suggested changes. Otherwise, if you do, always use "request changes". Since that change (if accepted) causes your approval to be dismissed, so you have to approve again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

Explanation in design docs about check as name

4 participants