-
Notifications
You must be signed in to change notification settings - Fork 0
docs: 📝 explain why we call it "check", not "validate" #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
joelostblom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but someone with more context needs to approve. One minor comment
signekb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to include an explanation of this decision 👌
Could this be a lot shorter by cutting out the paragraphs comparing and explaning the difference between "validate" and "verify"? I'm not sure it's relevant now that we use "check". Couldn't the argument simply be that the word "validate" is used a lot of places in a way that doesn't align with what the word actually means, and therefore, we use the word "check" instead?
Co-authored-by: Signe Kirk Brødbæk <signebroedbaek@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍 I still think this could be shorter (😬), but if you prefer to keep as is that's fine with me too.
I do have some minor suggestions again:
|
@signekb if you have suggestions to shorten it, please do give them! 😝 |
|
I'll give it a go when you've implemented the suggestions you prefer from my review 👍 |
Co-authored-by: Signe Kirk Brødbæk <signebroedbaek@gmail.com>
Co-authored-by: Signe Kirk Brødbæk <signebroedbaek@gmail.com>
signekb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alrighty. This might be controversial. Let me know what you think :)
Co-authored-by: Signe Kirk Brødbæk <signebroedbaek@gmail.com>
joelostblom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read well to me!
Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com>
|
@joelostblom just fyi, when you approve, don't include a comment change if you have no suggested changes. Otherwise, if you do, always use "request changes". Since that change (if accepted) causes your approval to be dismissed, so you have to approve again. |
Description
I wanted to explain why we don't use validate, for any readers who are interested.
Closes #181
Needs an in-depth review.
Checklist
just run-all