Skip to content

feat: add flag -exclude-analyzers #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add flag -exclude-analyzers #1420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions cmd/gosec/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,9 @@ var (
// rules to explicitly exclude
flagRulesExclude = vflag.ValidatedFlag{}

// exclude Analyzer-based rules
flagExcludeAnalyzers = flag.Bool("exclude-analyzers", false, "Exclude rules that require SSA analysis, which improves performance considerably")

// rules to explicitly exclude
flagExcludeGenerated = flag.Bool("exclude-generated", false, "Exclude generated files")

Expand Down Expand Up @@ -252,8 +255,12 @@ func loadRules(include, exclude string) rules.RuleList {
return rules.Generate(*flagTrackSuppressions, filters...)
}

func loadAnalyzers(include, exclude string) *analyzers.AnalyzerList {
func loadAnalyzers(include, exclude string, excludeAnalyzers bool) *analyzers.AnalyzerList {
var filters []analyzers.AnalyzerFilter
if excludeAnalyzers {
logger.Println("Excluding all analyzers")
filters = append(filters, analyzers.NewAnalyzerFilter(false))
} else {
if include != "" {
logger.Printf("Including analyzers: %s", include)
including := strings.Split(include, ",")
Expand All @@ -268,6 +275,7 @@ func loadAnalyzers(include, exclude string) *analyzers.AnalyzerList {
filters = append(filters, analyzers.NewAnalyzerFilter(true, excluding...))
} else {
logger.Println("Excluding analyzers: default")
}
}
return analyzers.Generate(*flagTrackSuppressions, filters...)
}
Expand Down Expand Up @@ -436,7 +444,7 @@ func main() {

ruleList := loadRules(includeRules, excludeRules)

analyzerList := loadAnalyzers(includeRules, excludeRules)
analyzerList := loadAnalyzers(includeRules, excludeRules, *flagExcludeAnalyzers)

if len(ruleList.Rules) == 0 && len(analyzerList.Analyzers) == 0 {
logger.Fatal("No rules/analyzers are configured")
Expand Down