Skip to content
This repository was archived by the owner on Oct 14, 2020. It is now read-only.

Commit fd54f57

Browse files
committed
#30 Rework the consequences part
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
1 parent 6e42744 commit fd54f57

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

docs/adr/adr_0001.adoc

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -207,12 +207,12 @@ Regarding question 2 we decided to implement the solution approach 1 with a job-
207207

208208
== Consequences
209209

210-
With the new `Hook Concept` we open the `DataProcessing` Phase 3 to a more intuitive and flexible architecture. It is easier to understand because _WebHooks_ are already a well known concept. It is possible to keep the existing implementation of the `persistenceProviders` and to integrate them with a lot of other possible data processing components in a more general fashion. In the end, this step will result in a lot of additional feature possibilities, which go fare beyond the existing ones. Therefore we only need to implement this concept once in the secureCodeBox Operator and new ideas for extending the DataProcessing will not enforce conceptual or architectural changes.
210+
With the new _hook concept_ we open the _phase 3 data processing_ to a more intuitive and flexible architecture. It is easier to understand because _WebHooks_ are already a well known concept. It is possible to keep the existing implementation of the _PersistenceProvider_ and integrate them with a lot of other possible data processing components in a more general fashion. In the end, this step will result in a lot of additional feature possibilities, which go far beyond the existing ones proposed here. Therefore we only need to implement this concept once in the _secureCodeBox operator_ and new ideas for extending the _DataProcessing_ will not enforce conceptual or architectural changes.
211211

212212
Ideas for additional data processing hooks:
213213

214-
* Notifier-Hooks (ReadOnlyHook) e.g., for chat (slack, teams etc.), metric, alerting systems
215-
* MetaData enrichment hooks (ReadAndWriteHook)
216-
* FilterData Hooks (e.g., false/positive handling) (ReadAndWriteHook)
217-
* SystemIntegration Hooks (ReadOnlyHook) e.g., for ticketing systems like Jira
218-
* CascadingScans Hooks (ReadOnlyHook) e.g., for starting new security scans based on findings
214+
* Notifier hooks (_ReadOnlyHook_) e.g., for chat (slack, teams etc.), metric, alerting systems
215+
* MetaData enrichment hooks (_ReadAndWriteHook_)
216+
* FilterData hooks (_ReadAndWriteHook_) (e.g., false/positive handling)
217+
* SystemIntegration hooks (_ReadOnlyHook_) e.g., for ticketing systems like Jira
218+
* CascadingScans hooks (_ReadOnlyHook_) e.g., for starting new security scans based on findings

0 commit comments

Comments
 (0)