Skip to content
This repository was archived by the owner on Oct 14, 2020. It is now read-only.

Commit 6e42744

Browse files
committed
#30 Rework the decission part
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
1 parent 66da9b4 commit 6e42744

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

docs/adr/adr_0001.adoc

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -181,17 +181,18 @@ Analog to kubernetes webhooks: HTTP server receiving findings and returning resu
181181

182182
== Decision
183183

184-
Regarding the Question 1 it seems that both solution approaches are resulting in the same execution model. We decided to implement solution approach 1 and unify both concepts into a more general concept with the name _"hook concept"_. Therefore we exchange the existing name `persistenceProvider` for phase 3 in the execution model with a more general term `DataProcessing`:
184+
Regarding question 1 it seems that both solution approaches are resulting in the same execution model. We decided to implement solution approach 1 and unify both concepts into a more general concept with the name _hook concept_. Therefore we exchange the existing name _PersistenceProvider_ for phase 3 in the execution model with a more general term _DataProcessing_:
185185

186+
// #30 I suggest the term "processing" instead of data processing/
186187
....
187188
┌──────────────────┐ ┌──────────────────┐ ┌──────────────────┐
188-
Scanning ├─────────▶│ Parsing ├─────────▶│ DataProcessing
189+
scanning ├─────────▶│ parsing ├─────────▶│ data processing
189190
│ (Phase 1) │ │ (Phase 2) │ │ (Phase 3) │
190191
└──────────────────┘ └──────────────────┘ └──────────────────┘
191192
....
192193

193-
Regarding the Question 2 we decided to implement the solution approach 1 with a job-based approach (no active service component needed).
194-
The Phase 3 `DataProcessing` will be therefore split into to separate phases named `ReadAndWriteHooks (3.1)` and `ReadOnlyHooks (3.2)`
194+
Regarding question 2 we decided to implement the solution approach 1 with a job-based approach (no active service component needed). Therefore the phase 3 _data processing_ will be split into two separate phases named _ReadAndWriteHooks_ (3.1) and _ReadOnlyHooks_ (3.2)
195+
// #30 to what refers 3.1 and 3.2?
195196

196197
....
197198
┌ DataProcessing: ReadOnlyHooks ─ ─ ─

0 commit comments

Comments
 (0)