Skip to content
This repository was archived by the owner on Oct 14, 2020. It is now read-only.

Commit 66da9b4

Browse files
committed
#30 Reqork the question 2 part
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
1 parent 6584335 commit 66da9b4

File tree

1 file changed

+24
-24
lines changed

1 file changed

+24
-24
lines changed

docs/adr/adr_0001.adoc

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -131,14 +131,14 @@ Keep _PersistenceProvider_ as they are and introduce new _MetaDataProvider_ CRD
131131

132132
* Not sure if it worth to introduce a new CRD for everything, especially when it's conceptually pretty close to to something already existing.
133133

134-
==== Question 2: How Should the Execution Model Look like for Each?
134+
==== Question 2: How Should the Execution Model Look like for Each Concept?
135135

136136
===== Solution Approach 1: Like the Persistence Provider
137137

138-
Basically a docker container which process takes two command line args:
138+
Basically a docker container which process findings takes two arguments:
139139

140-
* A pre-signed URL to download the findings from
141-
* A pre-signed URL to upload the modified findings to
140+
. A pre-defined URL to download the findings from.
141+
. A pre-defined URL to upload the modified findings to.
142142

143143
Examples:
144144

@@ -148,36 +148,36 @@ Examples:
148148

149149
====== Pros
150150

151-
* on liner with the current implementations
152-
* code overhead / wrapper code is pretty minimal
153-
* zero scale - no resource costs when nothing is running
151+
* One liner with the current implementations.
152+
* Code overhead / wrapper code is pretty minimal.
153+
* Zero scale: no resource costs when nothing is running.
154154

155155
===== Cons
156156

157-
* results in too many k8s jobs?
158-
** resource blocking on finished resources
159-
** ttlAfterFinished enabled
160-
* container runtime overhead (especially time)
157+
* May results in too many Kubernetes jobs.
158+
** Resource blocking on finished resources.
159+
** `ttlAfterFinished` enabled.
160+
* Container runtime overhead (especially time).
161161

162-
=== Option 2: A WebHooks Like Concept
162+
===== Solution Approach 2: A WebHooks Like Concept
163163

164-
Analog to kubernetes webhooks. Https server receiving findings and returning results.
164+
Analog to kubernetes webhooks: HTTP server receiving findings and returning results.
165165

166-
==== Pros
166+
===== Pros
167167

168-
* MilliSeconds instead of seconds for processing
169-
* No ContainerCreation Overhead
170-
* No additional k8s jobs needed
168+
* Milliseconds instead of seconds for processing.
169+
* No overhead for container Creation.
170+
* No additional kubernetes jobs needed.
171171

172172
===== Cons
173173

174-
* Introduces new running Services that need to be maintained and have uptime
175-
* Code Overhead / Boilerplate (Can be mitigated by SDK)
176-
* Debugging of individual MetaDataProvider is harder as everything is handled by a single service
177-
* Introduces "New" Concept
178-
* Certificate Management for webhook services (`cert-manager` required by default?)
179-
* Scaling for systems with lots of load could be a problem
180-
* One service per namespace (multiple tenants) needed => results in many running active services which is resource consuming
174+
* Introduces new running services which needs to be maintained and have uptime.
175+
* Code overhead / boilerplate (Can be mitigated by an SDK).
176+
* Debugging of individual _MetaDataProvider_ is harder than a single service which handles everything.
177+
* Introduces "`new`"cConcept.
178+
* Certificate management for webhook services (`cert-manager` required by default?).
179+
* Scaling for systems with lots of load could be a problem.
180+
* One service per namespace (multiple tenants) needed -> results in many running active services which is resource consuming.
181181

182182
== Decision
183183

0 commit comments

Comments
 (0)