Add support to lsl preprocessing for <> style includes #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: WolfGangS <flamin2k8@gmail.com>
Rider-Linden
approved these changes
Dec 4, 2025
Rider-Linden
reviewed
Dec 4, 2025
Collaborator
Rider-Linden
left a comment
Rider-Linden
left a comment
There was a problem hiding this comment.
I keep going back and forth on this... I'm tempted to suggest we add < and > into the LANGUAGE_CONFIGS in lexer.ts... but I'm not sure that's feasible.
Contributor
Author
|
It could be done as a "more involved" tokenizing check. Really at that point you are moving on to the beginings of parsing into an ast At some point I would like to do that, so that code optimizations can be run against the ast Personally i think for now, this ads the compatibility with minimal changes. If we upgrade from just streaming tokens to building a more advanced representation then this can be reevaluated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The firestorm preproc supports includes with the following format
This pr adds support for that to allow for maximum compatibility with preexisting code.
Also includes test for said case.
Addresses part 1 of #32