Skip to content

Patch allocation bug #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Patch allocation bug #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e73fc49
early return when max_hexagons is negative
bschrag620 Sep 5, 2025
1fabde0
add spec
bschrag620 Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/h3/traversal.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,9 +299,12 @@ def k_ring_distances(origin, k)
# @return [Array<Integer>] H3 indexes
def line(origin, destination)
max_hexagons = line_size(origin, destination)
raise(ArgumentError, "Could not compute line") if max_hexagons.negative?

hexagons = H3Indexes.of_size(max_hexagons)
res = Bindings::Private.h3_line(origin, destination, hexagons)
raise(ArgumentError, "Could not compute line") if res.negative?

hexagons.read
end

Expand Down
11 changes: 10 additions & 1 deletion spec/traversal_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
it "raises an error" do
expect { max_kring_size }.to raise_error(RangeError)
end
end
end
end

describe ".k_ring_distances" do
Expand Down Expand Up @@ -364,5 +364,14 @@
subject(:line) { H3.line(origin, destination) }

it { is_expected.to eq(result) }

context "when a line cannot be drawn" do
let(:origin) { "872889b8affffff".to_i(16) }
let(:destination) { "872aa6c80ffffff".to_i(16) }

it "should raise an ArgumentError" do
expect { subject }.to raise_error(ArgumentError)
end
end
end
end