Align request properties with URL spec

Author: phpnode

src/lib/seam/connect/seam-http-request.ts

@@ -11,9 +11,8 @@ interface SeamHttpRequestParent {
 }
 
 export interface SeamHttpRequestConfig<TBody, TResponseKey> {
-  readonly url?: string
+  readonly path?: string
   readonly method?: Method
-  readonly params?: any
   readonly data?: TBody
   readonly responseKey: TResponseKey
   readonly options?: Pick<SeamHttpRequestOptions, 'waitForActionAttempt'>
@@ -43,18 +42,14 @@ export class SeamHttpRequest<
     return this.#config.responseKey
   }
 
-  public get url(): string {
-    return this.#config.url ?? ''
+  public get path(): string {
+    return this.#config.path ?? ''
   }
 
   public get method(): Method {
     return this.#config.method ?? 'get'
   }
 
-  public get params(): any {
-    return this.#config.params
-  }
-
   public get data(): TBody {
     return this.#config.data as TBody
   }
@@ -64,9 +59,8 @@ export class SeamHttpRequest<
   > {
     const { client } = this.#parent
     const response = await client.request({
-      url: this.url,
+      url: this.path,
       method: this.method,
-      params: this.params,
       data: this.data,
     })
     if (this.responseKey === undefined) {

test/seam/connect/seam-http-request.test.ts

@@ -12,7 +12,7 @@ test('returns a SeamHttpRequest', async (t) => {
   const deviceRequest = seam.devices.get({ device_id: seed.august_device_1 })
 
   t.true(deviceRequest instanceof SeamHttpRequest)
-  t.is(deviceRequest.url, '/devices/get')
+  t.is(deviceRequest.path, '/devices/get')
   t.deepEqual(deviceRequest.data, {
     device_id: seed.august_device_1,
   })