Move ResponseFromSeamHttpRequest to test

Author: phpnode

src/lib/seam/connect/seam-http-request.ts

@@ -16,16 +16,9 @@ export interface SeamHttpRequestConfig<TBody, TResponseKey> {
   readonly params?: any
   readonly data?: TBody
   readonly responseKey: TResponseKey
-  readonly options: Pick<SeamHttpRequestOptions, 'waitForActionAttempt'>
+  readonly options?: Pick<SeamHttpRequestOptions, 'waitForActionAttempt'>
 }
 
-export type ResponseFromSeamHttpRequest<T> =
-  T extends SeamHttpRequest<any, infer TResponse, infer TResponseKey>
-    ? TResponseKey extends keyof TResponse
-      ? TResponse[TResponseKey]
-      : undefined
-    : never
-
 export class SeamHttpRequest<
   const TBody,
   const TResponse,
@@ -58,7 +51,7 @@ export class SeamHttpRequest<
     return this.#config.method ?? 'get'
   }
 
-  public get params() {
+  public get params(): any {
     return this.#config.params
   }
 
@@ -84,7 +77,7 @@ export class SeamHttpRequest<
     const data = response.data[this.responseKey]
     if (this.responseKey === 'action_attempt') {
       const waitForActionAttempt =
-        this.#config.options.waitForActionAttempt ??
+        this.#config.options?.waitForActionAttempt ??
         this.#parent.defaults.waitForActionAttempt
       if (waitForActionAttempt !== false) {
         return await resolveActionAttempt(

test/seam/connect/seam-http-request.test.ts

@@ -3,12 +3,9 @@ import { getTestServer } from 'fixtures/seam/connect/api.js'
 
 import { SeamHttp } from '@seamapi/http/connect'
 
-import {
-  type ResponseFromSeamHttpRequest,
-  SeamHttpRequest,
-} from 'lib/seam/connect/seam-http-request.js'
+import { SeamHttpRequest } from 'lib/seam/connect/seam-http-request.js'
 
-test('serializes array params when undefined', async (t) => {
+test('returns a SeamHttpRequest', async (t) => {
   const { seed, endpoint } = await getTestServer(t)
   const seam = SeamHttp.fromApiKey(seed.seam_apikey1_token, { endpoint })
 
@@ -34,3 +31,10 @@ test('serializes array params when undefined', async (t) => {
   const invalidDeviceType: Expected['device_type'] = 'invalid_device_type'
   t.truthy(invalidDeviceType)
 })
+
+type ResponseFromSeamHttpRequest<T> =
+  T extends SeamHttpRequest<any, infer TResponse, infer TResponseKey>
+    ? TResponseKey extends keyof TResponse
+      ? TResponse[TResponseKey]
+      : undefined
+    : never