Skip to content

Conversation

@Andrewsooter442
Copy link
Contributor

No description provided.

@Andrewsooter442 Andrewsooter442 changed the base branch from dev to refactor October 10, 2025 22:10
Copy link
Contributor

@4adex 4adex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add exhaustive tests for the server, and move the api_server to a new directory named clients at the hierarchy of crates. All clients will go in that directory

.await
.unwrap();
axum::serve(listener, app.into_make_service())
.await
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 let listener = TcpListener::bind(config.listen_addr)
        .await
        .map_err(|e| ..)?;
    axum::serve(listener, app.into_make_service())
        .await
        .map_err(|e| ..)?;

Here map the errors and pass them gracefully instead of using unwraps,
define new error types if you want. Also this might be independent of core crates so you need to define different error type.

@4adex
Copy link
Contributor

4adex commented Oct 14, 2025

Else looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants