Skip to content

Introduce SelectFields — alternative #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: feat-fields-disabled
Choose a base branch
from
Open

Introduce SelectFields — alternative #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9d0d150
introduce SelectField to ItemPage
BurnzZ Feb 21, 2023
50ba2b6
implement item_from_select_fields and fields_to_extract
BurnzZ Feb 21, 2023
db2e5ce
revert mypy tests for on_unknown_field
BurnzZ Feb 21, 2023
e3c6a52
avoid using kw_only in pages by using converter in ItemPage for Selec…
BurnzZ Feb 22, 2023
1d4240e
handle invalid SelectField usage
BurnzZ Feb 23, 2023
6de5cc0
update item_from_select_fields() to always call .to_item()
BurnzZ Feb 27, 2023
227b610
improve docstrings and type annotations
BurnzZ Feb 27, 2023
77b06ca
add call_counter to all tests
BurnzZ Feb 27, 2023
0096c8e
fix rebase conflict in _skip_nonitem_fields
BurnzZ Mar 1, 2023
e316cc9
ensure parity with skip_nonitem_fields
BurnzZ Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .flake8
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ per-file-ignores =
web_poet/testing/pytest.py:D102
tests/po_lib_to_return/__init__.py:D102
tests/test_testing.py:D102
tests/test_fields.py:D102

# the suggestion makes the code worse
tests/test_serialization.py:B028
Loading