Skip to content

Upgrade to Gradle 9.1.0 #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Upgrade to Gradle 9.1.0 #212

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
170717f
Upgrade to Gradle 9.1.0
dylanowen Oct 8, 2025
00b4ede
Fixed aggregate task concurrent access
dylanowen Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/main/groovy/org/scoverage/ScoveragePlugin.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,10 +298,8 @@ class ScoveragePlugin implements Plugin<PluginAware> {
it.logger.warn("Scala sub-project '${it.name}' doesn't have Scoverage applied and will be ignored in parent project aggregation")
}
}
def childReportTasks = project.subprojects.findResults {
it.tasks.find { task ->
task.name == REPORT_NAME && task instanceof ScoverageAggregate
}
def childReportTasks = project.subprojects.collectMany {
it.tasks.withType(ScoverageAggregate).matching { it.name == REPORT_NAME }
Copy link
Contributor

@maiflai maiflai Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks - is this a problem for projects under gradle 9 and up?

Copy link
Author

@dylanowen dylanowen Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've forgotten the exact error here but I'm pretty sure some method the original code was using has been deprecated/removed.

}
def allReportTasks = childReportTasks + globalReportTask.get()
def allSources = project.objects.fileCollection()
Expand Down