Improve logging #151
Closed
Improve logging #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, the setLevel(String classOrPackageName, int level) method was public in AbstractLogService, but not part of the LogService API.
This is a backwards incompatible change.
We do the level check in the level-specific methods now, in preparation for the protected log(int level, Object msg, Throwable t) method to become the central override point of concrete implementations. That way, specific implementations will not need to worry about filtering based on level in the typical case.
When logging critical messages (WARN and ERROR levels), use stderr. When logging non-critical messages (e.g., INFO level), use stdout. This change will be very useful for differentiating between different log levels in a simpler way; in particular, ImageJ can send both stdout and stderr to a Console window, coloring stderr messages in red and setting the Console to visible when they occur, but not displaying the Console by default when only stdout messages occur (because many ImageJ plugins spam stdout with lots of debugging output).
Member
Author
|
Merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MERGE ONLY IN CONCERT WITH THE OTHER 3.0.0 BRANCHES.
Log
WARNandERRORtostderr, and other levels tostdout.See also scijava/scijava-config@dcf378f.