Skip to content

For the case of the 1 second sleep, the test will fail before the sleep. #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: cboulay/apple_framework
Choose a base branch
from
+7 −3
Open

For the case of the 1 second sleep, the test will fail before the sleep. #240

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0e68c6
For the case of the 1 second sleep, the test will fail before the sleep.
zeyus Nov 4, 2025
9986781
Intermittent failure on OSX runners in stream resolution, fix part 2
zeyus Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions testing/ext/discovery.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,20 @@
namespace {

TEST_CASE("resolve multiple streams", "[resolver][basic]") {
lsl::continuous_resolver resolver("type", "Resolve", 50.);
// First create the outlets (to avoid extra waiting for
// multiple resolves)
std::vector<lsl::stream_outlet> outlets;
const int n = 3;
for (int i = 0; i < n; i++)
outlets.emplace_back(lsl::stream_info("resolvetest_" + std::to_string(i), "Resolve"));
lsl::continuous_resolver resolver("type", "Resolve", 50.);

// Verify with one-time resolve
auto found_stream_info = lsl::resolve_stream("type", "Resolve", n, 2.0);
REQUIRE(found_stream_info.size() == n);

// Allow the resolver a bit more time in case the first resolve wave was too fast
std::this_thread::sleep_for(std::chrono::seconds(1));
// Allow for enough time (interval, min_rtt)
std::this_thread::sleep_for(std::chrono::milliseconds(1600));
REQUIRE(resolver.results().size() == n);
}

Expand Down
Loading