Backport to branch(3) : Refactor TableMetadataService to Use DistributedTransactionAdmin Instead of DistributedStorageAdmin

[feeblefakie]

This is an automated backport of the following:

• Original PR: Refactor TableMetadataService to Use DistributedTransactionAdmin Instead of DistributedStorageAdmin #3146
• Backported commit: 36d27b9

Please merge this PR after all checks have passed.

[gemini-code-assist]

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is an automated backport that refactors the TableMetadataService to depend on DistributedTransactionAdmin instead of DistributedStorageAdmin. This change ensures that metadata operations within the data loader CLI tools are handled through the appropriate transactional administration interface, leading to more consistent and robust behavior, and includes improved resource handling.

Highlights

• Refactoring TableMetadataService: The core change involves refactoring the TableMetadataService to utilize DistributedTransactionAdmin instead of DistributedStorageAdmin for retrieving table metadata. This aligns the service with transactional administration capabilities.
• Updated Data Loader CLI Commands: Both ExportCommand and ImportCommand in the data-loader CLI module have been updated to reflect this change, ensuring they correctly initialize TableMetadataService with the new DistributedTransactionAdmin.
• Resource Management Improvement: The ExportCommand now properly closes the DistributedTransactionAdmin instance using a try-with-resources statement, improving resource management and preventing potential leaks.
• Test Updates: Corresponding unit tests for TableMetadataService have been updated to use DistributedTransactionAdmin mocks, ensuring the refactored logic is correctly tested and validated.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the code to use DistributedTransactionAdmin instead of DistributedStorageAdmin for retrieving table metadata. The changes are applied consistently across ExportCommand, ImportCommand, and TableMetadataService, including updates to the corresponding tests. The use of TransactionFactory to obtain the admin interface and the try-with-resources block for managing its lifecycle are correctly implemented. This refactoring improves the code by using a more appropriate abstraction for metadata operations within a transactional context. The changes are clean and correct.