Backport to branch(3) : Fix secondary index behavior in Consensus Commit

[feeblefakie]

This is an automated backport of the following:

• Original PR: Fix secondary index behavior in Consensus Commit #3133
• Backported commit: 59695df

Please merge this PR after all checks have passed.

[gemini-code-assist]

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request backports a crucial enhancement to Consensus Commit, enforcing stricter validation rules for operations involving secondary indexes and transaction metadata columns, particularly under the SERIALIZABLE isolation level. The changes prevent potential data inconsistencies by explicitly disallowing certain index-based Get and Scan operations, as well as conditions on indexed columns in cross-partition scans, when operating under SERIALIZABLE isolation. This is achieved through a refactored and consolidated operation checking mechanism, now residing in the ConsensusCommitOperationChecker class, which ensures more robust and predictable transactional behavior.

Highlights

• Stricter Secondary Index Enforcement: Get and Scan operations utilizing secondary indexes are now explicitly disallowed under the SERIALIZABLE isolation level, unless the indexed column is part of the primary key. Attempting these operations will now result in an IllegalArgumentException.
• Cross-Partition Scan Restrictions: For ScanAll operations executed with SERIALIZABLE isolation, conditions applied to indexed columns (that are not part of the primary key) are now prohibited to maintain transactional integrity.
• Refactored Operation Checking Logic: The validation logic for Get, Scan, and Mutation operations has been consolidated and moved into a new, comprehensive class named ConsensusCommitOperationChecker, replacing the previous ConsensusCommitMutationOperationChecker.
• New Error Codes for Clarity: Several new error codes have been introduced to provide more precise feedback when disallowed operations are attempted, such as using transaction metadata columns in projections or orderings, or performing restricted index operations in SERIALIZABLE isolation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request backports a fix for secondary index behavior in Consensus Commit. The changes introduce restrictions on using secondary indexes with SERIALIZABLE isolation level, disallowing Get and Scan operations on them. It also refactors the operation validation logic by replacing ConsensusCommitMutationOperationChecker with a more comprehensive ConsensusCommitOperationChecker. The changes are logical and well-tested. However, I've identified a critical issue where some of the new error messages are formatted incorrectly, which will lead to a runtime exception.