Backport to branch(3) : Fix incorrect validation causing maxThreads to be treated as required

[feeblefakie]

This is an automated backport of the following:

• Original PR: Fix incorrect validation causing maxThreads to be treated as required #3128
• Backported commit: a866640

Please merge this PR after all checks have passed.

[gemini-code-assist]

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue in the data loader CLI where the maxThreads parameter was erroneously considered mandatory, preventing the application of its intended default value. The changes streamline the command-line argument parsing and internal option management, ensuring that the number of available CPU cores is automatically used as the default for maxThreads when no value is provided. Additionally, it introduces a new --max-threads option while gracefully deprecating the older --threads option, maintaining backward compatibility and promoting a clearer naming convention.

Highlights

• Max Threads Defaulting: The maxThreads option for both data export and import commands now correctly defaults to the number of available processors if not explicitly specified by the user, fixing an issue where it was incorrectly treated as a required parameter.
• Deprecated Option Handling: The --threads command-line option has been deprecated and replaced with --max-threads. The system now properly handles the deprecated option for backward compatibility, mapping its value to the new --max-threads parameter.
• Refactored Option Management: The internal handling of maxThreads in ExportOptions and ImportOptions has been refactored to use @Builder.Default, ensuring the default value is applied consistently at the options object creation level.
• Enhanced Test Coverage: New unit tests have been added for both export and import commands to verify the correct behavior of the new default maxThreads value, the explicit --max-threads option, and the deprecated --threads option.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a backport that fixes an incorrect validation issue where maxThreads was treated as a required parameter. The changes correctly make the parameter optional, setting a default value based on available processors when it's not provided. This is done by changing the parameter's type from int to Integer and adjusting the validation logic. The changes also introduce a deprecated --threads option for backward compatibility and simplify the core logic by setting a default in the ExportOptions and ImportOptions builders. The new tests are comprehensive, covering the new behavior, the deprecated option, and the default value assignment. I've added a couple of suggestions to improve the robustness of the new tests by reducing logic duplication. Overall, this is a solid and well-tested fix.