Backport to branch(3.16) : Fix incorrect validation causing maxThreads to be treated as required

[feeblefakie]

This is an automated backport of the following:

• Original PR: Fix incorrect validation causing maxThreads to be treated as required #3128
• Backported commit: a866640

Please merge this PR after all checks have passed.

[gemini-code-assist]

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request backports a critical fix that rectifies an incorrect validation behavior in the data loader's export and import commands. Previously, the maxThreads option was erroneously treated as a mandatory parameter, leading to unnecessary validation failures. The updated logic now ensures that if maxThreads is not specified, it gracefully defaults to the system's available CPU processors, enhancing the robustness and user-friendliness of the data loader. Furthermore, this change introduces a new --max-threads option while ensuring backward compatibility for the deprecated --threads option.

Highlights

• Corrected maxThreads Validation: The maxThreads argument for data export and import commands is no longer treated as a required field, resolving an issue where its absence would cause validation errors.
• Automatic Default for maxThreads: If the maxThreads option is not explicitly provided by the user, it now automatically defaults to the number of available CPU processors on the system, improving ease of use.
• Deprecation of --threads Option: The older --threads command-line option has been deprecated. Users are encouraged to use the new --max-threads option instead, with backward compatibility ensured for existing scripts.
• Refactored Thread Count Handling: The logic for determining the default thread count has been moved from the ExportManager and ImportCommand classes into their respective ExportOptions and ImportOptions builder classes, centralizing default value management.
• Enhanced Test Coverage: New unit tests have been added for both export and import commands and their options to thoroughly verify the correct handling of maxThreads defaults, explicit values, and deprecated options.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively resolves an incorrect validation issue for the maxThreads option. By changing the type from int to Integer in the command-line options, the code can now correctly differentiate between a user-provided value and an omitted one. The validation is now only triggered when the user specifies the option, and a sensible default based on available processors is used otherwise. This fix has been consistently applied to both the export and import commands.

The related refactoring to centralize the default value logic into the core ExportOptions and ImportOptions classes using @Builder.Default is a good improvement that simplifies the manager classes. The introduction of new unit tests to cover these changes, including the handling of deprecated options, ensures the new logic is well-verified. Overall, the changes are well-implemented, improving both correctness and maintainability.