revert: Add back an option to enable bsp in the presentation compiler #24481
Conversation
|
Another issue seems that sbt is giving a wrong classpath to metals now. |
tgodzik
force-pushed
the
add-back-enable
branch
from
f55c22f to
26b062e
Compare
tgodzik
force-pushed
the
add-back-enable
branch
2 times, most recently
from
31113d7 to
1c30392
Compare
|
Should be rebased on top of this (#24483) if possible. |
tgodzik
force-pushed
the
add-back-enable
branch
3 times, most recently
from
ea506fc to
18d8cc9
Compare
|
Should be good now, the flag is now enabled only in the project that the PC depends on, otherwise we would not get the full classpath. |
hamzaremmal
left a comment
hamzaremmal
left a comment
There was a problem hiding this comment.
To achieve the purpose of this PR, we only need to change all the bspEnabled := false, to bspEnabled := enableBspAllProjects,. Nothing more than that.
project/Build.scala
Outdated
| // Generate library.properties, used by scala.util.Properties | ||
| Compile / resourceGenerators += generateLibraryProperties.taskValue | ||
| Compile / resourceGenerators += generateLibraryProperties.taskValue, | ||
| bspEnabled := enableBspAllProjects, |
There was a problem hiding this comment.
This is just wrong. I don't want to have to enable BSP in every project to have the non-bootstrapped stdlib (the root of every scala project in the Build).
There was a problem hiding this comment.
It does work without this part, though I don't think there anything "just wrong" about it. Saying I don't think we need this part would probably suffice and avoid using loaded language.
tgodzik
force-pushed
the
add-back-enable
branch
from
18d8cc9 to
e4fe715
Compare
tgodzik
force-pushed
the
add-back-enable
branch
from
e4fe715 to
2b2c34a
Compare
3 participants
I don't see a reason why it was removed, please let me know next time when there is some changes to this part.