Skip to content

Fix #24440: Do not check public flexible types on artifact symbols or inside anonymous classes #24471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2025
+20 −2
Merged

Fix #24440: Do not check public flexible types on artifact symbols or inside anonymous classes #24471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b556293
Do not check public flexible types on artifact symbols
noti0na1 Nov 18, 2025
1a72dc6
Prevent checking public flexible types on anonymous classes
noti0na1 Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions compiler/src/dotty/tools/dotc/typer/RefChecks.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1202,8 +1202,9 @@ object RefChecks {
/** Check that public (and protected) methods/fields do not expose flexible types. */
def checkPublicFlexibleTypes(sym: Symbol)(using Context): Unit =
if ctx.explicitNulls && !ctx.isJava
&& sym.exists && !sym.is(Private) && sym.owner.isClass
&& !sym.isOneOf(Synthetic | InlineProxy | Param | Exported) then
&& sym.exists && sym.owner.isClass
&& !sym.owner.isAnonymousClass
&& !sym.isOneOf(JavaOrPrivateOrSynthetic | InlineProxy | Param | Exported) then
val resTp = sym.info.finalResultType
if resTp.existsPart(_.isInstanceOf[FlexibleType], StopAt.Static) then
report.warning(
Expand Down
17 changes: 17 additions & 0 deletions tests/explicit-nulls/pos/i24440.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
//> using options -Yexplicit-nulls -Werror

trait AwtComponentLogging extends java.awt.Component:

override def getPreferredSize: java.awt.Dimension =
val dim: java.awt.Dimension = super.getPreferredSize
dim

private def superPS1 = super.getPreferredSize

private val superPS2 = super.getPreferredSize

class Test:
def getCompoment: java.awt.Component =
new java.awt.Component {
override def getPreferredSize = super.getPreferredSize
}
Loading