Add Unscoped classifier #24470
Merged
Add Unscoped classifier #24470
+763
−221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- FreshCaps with Unscoped classifier are assumed to be owned by the enclosing toplevel class - FreshCaps with unscoped classifier are not turned into ResultCaps in the return types of anonymous functions.
Also: Improve consume message
odersky
force-pushed
the
add-unscoped
branch
from
f0f61ed to
21e7a30
Compare
Allow both .only[C] and .rd (in this order).
If a class has fresh fields and all fields are read-only, only imply `cap.rd`, not `cap`.
Treat it like an expression `e` instead.
3 tasks
We don't want to know what the argument type was, since a consume parameter gets integrated in the class cap.
bracevac
reviewed
Nov 20, 2025
Contributor
There was a problem hiding this comment.
Note: We still have some quirks w.r.t. classifiers which should be addressed in a follow-up PR.
bracevac
approved these changes
Nov 20, 2025
Contributor
bracevac
left a comment
bracevac
left a comment
There was a problem hiding this comment.
LGTM. We also need to make sure that scaladoc still works.
It should once this is merged, because it still relies on read-only not being a .only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the same time, drop Read classifier and the idea that .rd is a kind of restriction. That does not work anymore since
.rdhas to be combinable with classified capabilities likeUnscoped.