Port Capture-checked Scala 2 collections #23769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
reviewed
Aug 19, 2025
odersky
approved these changes
Aug 19, 2025
Contributor
odersky
left a comment
odersky
left a comment
There was a problem hiding this comment.
See my question about LazyKetSet. This should still be addressed but it can be a separate PR.
hamzaremmal
reviewed
Aug 19, 2025
hamzaremmal
reviewed
Aug 19, 2025
library/src/scala/collection/immutable/StrictOptimizedSeqOps.scala
Outdated
Show resolved
Hide resolved
hamzaremmal
requested changes
Aug 19, 2025
Member
hamzaremmal
left a comment
hamzaremmal
left a comment
There was a problem hiding this comment.
All good, Martin's upcoming PR should solve all the issues with the bound checker for caps.Pure. There is one added bounded that will not be covered by that check and needs to be (dropped ?) solved.
odersky
approved these changes
Aug 19, 2025
Contributor
|
PR for pure checking: #23784 |
hamzaremmal
approved these changes
Aug 19, 2025
Contributor
|
I'm going to bed now. If the tests are green we can merge. |
bracevac
approved these changes
Aug 19, 2025
hamzaremmal
added a commit
to hamzaremmal/scala3
that referenced
this pull request
Sep 11, 2025
This was introduced in scala#23769 but it makes the following test fail: https://github.com/scala/scala3/blob/48bc891bd317a62956dc86297feb6e86a73083f6/tests/run/t4954.scala#L8
hamzaremmal
added a commit
to hamzaremmal/scala3
that referenced
this pull request
Sep 12, 2025
This was introduced in scala#23769 but it makes the following test fail: https://github.com/scala/scala3/blob/48bc891bd317a62956dc86297feb6e86a73083f6/tests/run/t4954.scala#L8
hamzaremmal
added a commit
to hamzaremmal/scala3
that referenced
this pull request
Sep 13, 2025
This was introduced in scala#23769 but it makes the following test fail: https://github.com/scala/scala3/blob/48bc891bd317a62956dc86297feb6e86a73083f6/tests/run/t4954.scala#L8
hamzaremmal
added a commit
to hamzaremmal/scala3
that referenced
this pull request
Sep 13, 2025
This was introduced in scala#23769 but it makes the following test fail: https://github.com/scala/scala3/blob/48bc891bd317a62956dc86297feb6e86a73083f6/tests/run/t4954.scala#L8
hamzaremmal
added a commit
to hamzaremmal/scala3
that referenced
this pull request
Sep 15, 2025
This was introduced in scala#23769 but it makes the following test fail: https://github.com/scala/scala3/blob/48bc891bd317a62956dc86297feb6e86a73083f6/tests/run/t4954.scala#L8
Gedochao
pushed a commit
that referenced
this pull request
Nov 17, 2025
HarrisL2
pushed a commit
to HarrisL2/scala3
that referenced
this pull request
Nov 18, 2025
Fixed in scala#23769. Closes scala#23225.
bracevac
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Nov 19, 2025
Fixed in scala#23769. Closes scala#23225.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
collection.immutable.LazyListIterable[A], implements Iterable and IterableOps.LazyListandStreamare not capture-checked. Note added toLazyList.New traitno longer neededcollection.StrictSeqOps[A, CC[_] <: Pure, C], which extends SeqOps (which can now be impure) and requires the implementation to be pure.Seqand other data structures extend this.Suspicious changes:
MapOps.keySetchanges implementation to be always strict, unless it is one of the library's known strict collectionsNot capture-checked (yet?)
collection.convert.impla.k.a Steppers, due to some purity problems (maybe because we don't compile steppers and rely on Scala 2, for specialization?).