Optionally use VarHandles for Lazy Vals when targeting JDK 9+ #637
+229
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ased on scala#24109 implementation if targeting JDK 9 or later
WojciechMazur
changed the title
WojciechMazur
commented
Nov 8, 2025
Comment on lines
+734
to
+735
| @tu lazy val MethodHandlesClass: TermSymbol = requiredModule("java.lang.invoke.MethodHandles") | ||
| @tu lazy val MethodHandles_lookup: Symbol = MethodHandlesClass.requiredMethod("lookup") |
Author
There was a problem hiding this comment.
No need to explicitlly guard these on JDK8: their usage is not reachable on JDK8
WojciechMazur
commented
Nov 8, 2025
WojciechMazur
commented
Nov 8, 2025
Comment on lines
+298
to
+301
| // Check if environment allows VarHandles, cached per run | ||
| private var canUseVarHandles: Boolean = compiletime.uninitialized | ||
| private var cachedContext: Context = compiletime.uninitialized | ||
| def useVarHandles(using Context) = { |
Author
There was a problem hiding this comment.
There's plenty of usages, the check might allocate on each usage mostly due to .toInt or .toIntOption conversions, so let's skip redundant calculations - unlikely to change
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports scala#24109 to LTS 3.3, but also keeps existing offset-based implementation.
VarHandles are used if either explicitly targeting JDK 9+ (using
--java-output-version) or when using implicit releae-versions and using JDK 9When using VarHandles additional static class initializers
<clint>might be generated, where previously these were not needed (see MiMa filter added for scala.Tuple) however, this change is likely a binary compatible. The JVM owns class initialization and there is never an explicit call site to in user bytecode, so link/load will still succeed.