Rework serialization testing #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@joescii Would you be so kind to review? |
|
Looks like a good call. I didn't know about the lib :) |
ashawley
force-pushed
the
serialization-rework
branch
from
7f0027f to
e443d2c
Compare
Member
Author
|
Thank you, Joe. I sense, it was just as well that you didn't use the library so you could get the runtime exception. Now any serialization tests won't compile unless the thing is a subclass of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Joe Barnes added some useful code in #155 to study serialization issues. The following makes some of those auxiliary testing functions more generally available. In particular, reusing them for the ScalaCheck branch in #110.