[WIP] Early preview of dart-sass parser backport

[mgreter]

Needs sass/sass-spec#1425

Please don't review, only leaving this here since I don't know when I'll have time to finish this up.
My vacations are over soon, so I don't know when I'll get around to complete this.
It's already semi usable, passing 80% of current spec tests.
Tried to preserve current libsass behavior, but
probably needs changes in eval stage too!
All the debug glory is still in the code!

Edit: I started to bring back some stuff to master in order to make this change a little bit smaller.
I also tagged all open issues that should be fixed by this backport/refactoring (ATM 76/120).

[mgreter]

Current state: 26 specs with (mostly minor) regressions, 122 newly passing

[mgreter]

Current state: all specs passing with around 150 newly passing

Ported scss, sass and css parser.
Lot of stuff still to do; most obvious:

• ParserStates for sourcemaps
• And correct error reporting
• Cleanup of import classes

Master: 3062 runs, 0 assertions, 0 failures, 0 errors, 829 skips
Branch: 3725 runs, 0 assertions, 0 failures, 0 errors, 748 skips

[mgreter]

Current state: 3906 runs, 0 assertions, 0 failures, 0 errors, 752 skips

[xzyfer]

What do you see as the next step to getting this landed?

…

On Sat., 20 Jul. 2019, 12:50 pm Marcel Greter, ***@***.***> wrote: Current state: 3906 runs, 0 assertions, 0 failures, 0 errors, 752 skips — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2918?email_source=notifications&email_token=AAENSWFWBI5SYVFQZXVA2FDQAJ4PBA5CNFSM4H2VW2A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2NE6MI#issuecomment-513429297>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAENSWA2KXYFYRTF5EQYKULQAJ4PBANCNFSM4H2VW2AQ> .

[mgreter]

@xzyfer Don't expect anything to land before winter.
I guess this should land for a 3.8 version (close to sass 4.0).

[mgreter]

Current stats: 4143 runs, 0 assertions, 0 failures, 0 errors, 148 skips

[mgreter]

Current stats: 5814 runs, 0 assertions, 0 failures, 0 errors, 1196 skips
Lots of new spec tests, mostly failing regarding @use, @forward and new math module.

[mgreter]

Took long enough, but will now try to go for a LibSass 4.0 alpha release.
Still want to discuss the C-API, it already has been simplified internally.
Once I get CI stable here I will open a new PR for getting that ready.
I hope to have a 4.0 beta out by start to middle 2021.

@xzyfer I hope no objections from you to move this forward?
Since I pretty much rewrote everything, a PR review seems impossible!
But I guess since we're officially deprecated, we have more leeway!?
Alternatively I could publish everything within my own forks?

[xzyfer]

🚢 agree the deprecation means there are no expectations on the state of master.

[mgreter]

Continued in #3135