Skip to content

Conversation

@kminek
Copy link
Contributor

@kminek kminek commented Apr 16, 2023

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues comma-separated list of tickets # fixed by the PR, if any

@samdark
Copy link
Owner

samdark commented Apr 16, 2023

That should work. @brandonkelly, would you please confirm?

@brandonkelly
Copy link

brandonkelly commented Apr 16, 2023

Similar problem with that – we’re overriding $target as a protected property (because that’s what it currently is in LoggerAwareTrait).

So now PHPStan is reporting:

Protected property craft\log\MonologTarget::$logger overriding public property samdark\log\PsrTarget::$logger should also be public.

Either one of these changes are fine if you just release it with a major version bump, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants