fix: correct return type of getSchemaType #85
+31
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noted that the return type of
getSchemaTypeis not correct. It looks to be derived frombut the actual declaration was
The
keyof typeof SCHEMA_TYPESis actually"length" | "push" | "pop" | "map" ...which is wrong.I made the
SCHEMA_TYPESa const array and created new simple type:to fix that issue.