Install pyx sources with meson #40686
Conversation
|
Documentation preview for this PR (built with commit 79bca41; changes) is ready! 🎉 |
|
Sure, why not? The only 'disadvantage' I can see is that the sdist is a little bit bigger. Are there any other side effects? There is a bug in the update-meson script that it only can handle one |
|
Ah, right. I was trying to avoid keeping duplicate pyx file lists that may get out of sync, but since this is scripted I guess there is no risk of that. |
antonio-rojas
changed the title
I can't think of any. If something comes up we could make it a meson option, but that would require adding a feature for the presence of source files so we could disable the relevant tests accordingly. As of now I don't think it's worth the effort. |
sagemathgh-40686: Install pyx sources with meson Currently the meson build doesn't install the pyx source files, as opposed to the setuptools build. This has caused/is causing several issues: - The method `sage_getsource` as well as ipython's own source viewer `??` don't work for cython methods. This creates an inconsistency with python methods, and breaks several tests when the sage source is not available (eg. distro packages). - It breaks the doc builder sagemath#39973 (comment) - It used to cause issues when accessing some methods (sagemath#39735), now worked around. The only reason why these issues are not present in sage-the-distro is that cython wrongly embeds the absolute paths of source files, which masks the issues as long as the source is present in its original location. But as soon as cython/cython#6755 is released this will affect all types of sage build. In any case, I believe being able to inspect the methods implementation from the sage interface itself is a valuable feature for mathematicians, which are its main user base. I have only done one dir so far so I don't waste my time in case this is rejected or a different implementation is proposed. I will do the rest when I get the OK. Fixes sagemath#39874 URL: sagemath#40686 Reported by: Antonio Rojas Reviewer(s): Tobias Diez
3 participants
Currently the meson build doesn't install the pyx source files, as opposed to the setuptools build. This has caused/is causing several issues:
sage_getsourceas well as ipython's own source viewer??don't work for cython methods. This creates an inconsistency with python methods, and breaks several tests when the sage source is not available (eg. distro packages).The only reason why these issues are not present in sage-the-distro is that cython wrongly embeds the absolute paths of source files, which masks the issues as long as the source is present in its original location. But as soon as cython/cython#6755 is released this will affect all types of sage build.
In any case, I believe being able to inspect the methods implementation from the sage interface itself is a valuable feature for mathematicians, which are its main user base.
I have only done one dir so far so I don't waste my time in case this is rejected or a different implementation is proposed. I will do the rest when I get the OK.
Fixes #39874