Add support for multiple values of the same name type #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
est31
approved these changes
Nov 25, 2025
Member
Author
|
@cpu want to take a look? |
Member
Yes, thanks for the ping. I will look in the next day or so. |
cpu
reviewed
Nov 26, 2025
Member
cpu
left a comment
cpu
left a comment
There was a problem hiding this comment.
I think this seems OK relative to the existing API, but should have test coverage. Probably at minimum that when we generate a cert with a multi-value DN that we can round trip it through x509-parser. Maybe also some consideration for CSRs?
This is a semver-incompatible change, so will need a version bump.
I would be in favor of holding the release until there's more semver-incompatible work to justify the churn. It doesn't seem particularly urgent IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81. This is a semver-incompatible change, so will need a version bump.