Allow NestedTemplateOnce to render directly to buffer when no filter is present #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I noticed that using the "Nested template" syntax generates .render_once() for those templates, which seems to use intermediate buffer. But TemplateOnce also has a .render_once_to() function. So it seems that when the template is not using any filter we can write the template directly to output buffer.
I update the translator.rs to do that, also updated the test (for NestedTemplateOnce without filter). The nested template with filter works as before.
Also I removed the 'suffix' parameter completely, as it seems like it was there just to insert the .render_once() call.