Skip to content

Formats floating-point negative zero correctly #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+18 −9
Open

Formats floating-point negative zero correctly #153

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed7953d
check explicitly for zero components for absolute value
PaulXiCao Oct 26, 2025
05e45e3
DRY cleanup via lambda
PaulXiCao Oct 26, 2025
c17e74d
add tests
PaulXiCao Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1238,16 +1238,17 @@ impl<T: Clone + Num> One for Complex<T> {

macro_rules! write_complex {
($f:ident, $t:expr, $prefix:expr, $re:expr, $im:expr, $T:ident) => {{
let abs_re = if $re < Zero::zero() {
$T::zero() - $re.clone()
} else {
$re.clone()
};
let abs_im = if $im < Zero::zero() {
$T::zero() - $im.clone()
} else {
$im.clone()
let abs = |x: &$T| {
if x.is_zero() {
$T::zero()
} else if *x < Zero::zero() {
$T::zero() - x.clone()
} else {
x.clone()
}
};
let abs_re = abs(&$re);
let abs_im = abs(&$im);

return if let Some(prec) = $f.precision() {
fmt_re_im(
Expand Down Expand Up @@ -2715,6 +2716,14 @@ pub(crate) mod test {
assert_eq!(format!("{}", c), "-10-10000i");
#[cfg(feature = "std")]
assert_eq!(format!("{:16}", c), " -10-10000i");

for re in [-0.0, 0.0] {
for im in [-0.0, 0.0] {
let d = Complex::new(re, im);
assert_eq!(format!("{}", d), "0+0i");
assert_eq!(format!("{:+}", d), "+0+0i");
}
}
}

#[test]
Expand Down