-
Notifications
You must be signed in to change notification settings - Fork 967
Fixes adjustment of max_width within macros #6651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@ytmimi, could you take a look? Happy to make changes if necessary. |
|
@Manishearth I see you merging some recent PRs. Do you know who can take a look at this? |
|
@csmulhern So we're trying to help spread out the maintainer burden, but there are a lot of open PRs right now and we're still triaging them. Open PRs which change formatted code are tricky because it needs to be determined if it's a rbeaking change or not. We'll get to them eventually, but no promises. It will help if you show a before and after of the formatted code. |
|
It seems like from the PR description that this doesn't actually impact formatting, this makes certain previously-unintentionally-invalid values of a config start working again. |
|
Yes, this (mostly*) shouldn't impact formatting. Today, we have a bunch of properties that control breakpoints for how long certain lines can be. This is primarily In order to support formatting in macros, it looks like rustfmt just trims down This change makes the reduction based on the indent symmetric across all of the max_width style properties, and adds a new method to ensure this is done universally. * The edge case where this would affect formatting would be if e.g. |
Fixes #5404.
Minimal example:
Without this change:
With this change: