Skip to content

Unlimit UNIX remove_dir_all() implementation #93160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from
Closed

Unlimit UNIX remove_dir_all() implementation #93160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
61bd4e9
WIP: looping version of unix remove_dir_all
cuviper Jan 19, 2022
7cf62c7
Temporarily remove special-cased Macos x86-64 implementation.
hkratz Jan 30, 2022
d2cfba1
Readd Macos x86-64 remove_dir_all() special case using dynamic symbols.
hkratz Jan 30, 2022
93e708b
Use limited Readdir cache and use openat(dirf, "..", O_NOFOLLOW) to g…
hkratz Jan 30, 2022
424189d
replace RawFd with BorrowedFd
hkratz Jan 30, 2022
65b740c
Store and compare with stat.st_dev as well when going back up via ..
hkratz Jan 30, 2022
12b456e
fix for some UNIXes: parent directory needs to be reopened after dele…
hkratz Jan 30, 2022
4641c56
Add ui test for calling remove_dir_all() on deep directory hierarchies.
hkratz Jan 31, 2022
752330f
test: safe depths for all platforms.
hkratz Jan 31, 2022
bc9f33c
WIP: lazy read dir datatype
hkratz Feb 2, 2022
a6953a5
refill complete cache if empty when going up
hkratz Feb 2, 2022
a6b94a4
cosmetics
hkratz Feb 2, 2022
20542dc
CI filesystem is apparently slow, 64K deep hierarchy takes <2sec. loc…
hkratz Feb 2, 2022
f591d57
correct limit for readdir cache
hkratz Feb 2, 2022
266aaaf
remove debug output (oops)
hkratz Feb 2, 2022
f0bc8a6
better inode reuse protection
hkratz Feb 5, 2022
aec1f45
expand test to include an empty dir/file in each directory
hkratz Feb 5, 2022
dafa41f
include parent of deletion root dir in reused inode check
hkratz Feb 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading