Rollup of 8 pull requests #92627
Merged
Rollup of 8 pull requests #92627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows changes from rust-lang#67967 and converts remaining `span_bug`s into delayed bugs, since for const items drop elaboration might be executed on a MIR which failed borrowck.
Upstream LLVM change 9290ccc migrated attribute removal to use AttributeMask instead of AttrBuilder, so we need to follow suit here.
A missing break statement lead to an infinite loop in bootstrap.py.
Avoids some extra conversions. Spotted by nikic during review.
Import `SimplifiedType` more
Rename `CStore::item_attrs` -> `CStore::item_attrs_untracked` top follow conventions
By avoiding formatting and allocations in the no-ident case, and by making the span mandatory if the ident exists. Use the optimized `opt_item_ident` to cleanup `fn each_child_of_item`
return the correct type for closures in `type_of` A bit unhappy about the way `typeck::check_crate` works rn. Would have preferred to not change `CollectItemTypesVisitor` in this way. r? ``@nikomatsakis``
… r=jackh726 Delay remaining `span_bug`s in drop elaboration This follows changes from rust-lang#67967 and converts remaining `span_bug`s into delayed bugs, since for const items drop elaboration might be executed on a MIR which failed borrowck. Fixes rust-lang#81708. Fixes rust-lang#91816.
Fix spacing and ordering of words in pretty printed Impl Follow-up to rust-lang#92238 fixing one of the FIXMEs. ```rust macro_rules! repro { ($item:item) => { stringify!($item) }; } fn main() { println!("{}", repro!(impl<T> Struct<T> {})); println!("{}", repro!(impl<T> const Trait for T {})); } ``` Before: `impl <T> Struct<T> {}` After: `impl<T> Struct<T> {}` Before: `impl const <T> Trait for T {}` 😿 After: `impl<T> const Trait for T {}`
Exit nonzero on rustc -Wall Previously `rustc -Wall /dev/null` would print a paragraph explaining that `-Wall` is not a thing in Rust, but would then exit 0. I believe exiting 0 is not the right behavior. For something like `rustc --version` or `rustc --help` or `rustc -C help` the user is requesting rustc to print some information; rustc prints that information and exits 0 because what the user requested has been accomplished. In the case of `rustc -Wall path/to/main.rs`, I don't find it correct to conceptualize this as "the user requested rustc to print information about the fact that Wall doesn't exist". The user requested a particular thing, and despite rustc knowing what they probably meant and informing them about that, the thing they requested has *not* been accomplished. Thus a nonzero exit code is needed.
RustWrapper: adapt to new AttributeMask API Upstream LLVM change 9290ccc migrated attribute removal to use AttributeMask instead of AttrBuilder, so we need to follow suit here. r? ``@nagisa`` cc ``@nikic``
…lacrum Break the loop A missing break statement lead to an infinite loop in bootstrap.py. I also added a short sleep so it's not constantly running at 100%. But I can remove that if it's not wanted. Fixes rust-lang#76661
rustc_metadata: Some minor cleanups and optimizations Mostly extracted from rust-lang#88679 (which is otherwise a rustdoc PR). r? ``@cjgillot``
…t_struct, r=Mark-Simulacrum Remove unused `ExtendDefault` struct As noted in rust-lang#77850 (comment), this struct is no longer used.
rustbot
added
T-compiler
Member
Author
|
@bors r+ rollup=never p=8 |
Collaborator
|
📌 Commit fcae1d6 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This was referenced Jan 7, 2022
Collaborator
|
Finished benchmarking commit (e012a19): comparison url. Summary: This change led to large relevant improvements 🎉 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
type_of#91055 (return the correct type for closures intype_of)span_bugs in drop elaboration #92207 (Delay remainingspan_bugs in drop elaboration)ExtendDefaultstruct #92620 (Remove unusedExtendDefaultstruct)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup