Skip to content

Remove pointer comparison check before doing memcmp #71735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Remove pointer comparison check before doing memcmp #71735

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcd3c1f
Remove ptr comparison check before doing memcmp
samrat May 1, 2020
5c4fc12
Add codegen test to verify pointer check is not emitted
samrat May 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/libcore/slice/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5859,9 +5859,6 @@ where
if self.len() != other.len() {
Copy link
Contributor

@bluss bluss May 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(15 lines above) There's still a pointer comparison in the default fn equal, probably remove in both places, if the comparisons should be removed

return false;
}
if self.as_ptr() == other.as_ptr() {
return true;
}
unsafe {
let size = mem::size_of_val(self);
memcmp(self.as_ptr() as *const u8, other.as_ptr() as *const u8, size) == 0
Expand Down