-
Notifications
You must be signed in to change notification settings - Fork 14.1k
Don't use static crt by default when build proc-macro #69519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
7ca1b2f
7996df9
89aebbd
84349cc
dbed65a
7a89bf1
75e6cfc
cfff1b4
afd374f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
| @@ -0,0 +1,15 @@ | ||||
| // Test proc-macro crate can be built without addtional RUSTFLAGS | ||||
| // on musl target | ||||
|
|
||||
| // build-pass | ||||
| // only-musl | ||||
|
||||
| --set target.x86_64-unknown-linux-musl.crt-static=false \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smaeul it failed on x86_64-gnu-llvm-7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The x86_64-gnu-llvm-7 job only builds for x86_64-unknown-linux-gnu. It doesn't look like it does anything with musl at all. So where did "--target=x86_64-unknown-linux-musl" in the rustc arguments for this test come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see, the old version of the test had compile-flags: --target=x86_64-unknown-linux-musl in it. That was the problem. After removing that line, the test should work on all targets.
So since the behavior tested here is not musl-specific, I would suggest 1) removing only-musl and 2) renaming the test to mention crt-static instead of musl.
Uh oh!
There was an error while loading. Please reload this page.