vxWorks is using "invalid argument" instead of "Invalid argument" in reporting invalid options #65185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync to rust-lang/rust branch master
use 'invalid argument' for vxWorks
Contributor
|
r? @rkruppe (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
Contributor
|
The diff seems fine to rubber-stamp, but Rust has a no merge policy so please rebase ae2bb7b to get rid of the merge commits (preserving that it was authored by @bpangWR, of course). |
Contributor
Author
|
I have been always using my personal account 'BaoshanPang' to make changes in github, but not sure why sometimes it recognize me as bpangWR which is the company account created by me. |
Contributor
|
Ah, OK, then authorship is no concern, please just get rid of the merge commits in whatever way is most convenient. |
Contributor
Author
|
Using a new branch is easier for me, I can't find a way to remove the "merge commits" in the current branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.