Replace Rvalue::NullaryOp by a variant in mir::ConstValue. #148766
+649
−938
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #148151
This PR fully removes the MIR
Rvalue::NullaryOp. After #148151, it was only useful for runtime checks likeub_checks,contract_checksandoverflow_checks.These are "runtime" checks, boolean constants that may only be
truein codegen. It depends on a rustc flag passed to codegen, so we need to represent those flags cross-crate.This PR replaces those runtime checks by special variants in MIR
ConstValue. This allows code that expects constants to manipulate those as such, even if we may not always be able to evaluate them to actual scalars.