-
Notifications
You must be signed in to change notification settings - Fork 14k
Add Crystal Durham to .mailmap #148710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Crystal Durham to .mailmap #148710
The head ref may contain hidden characters: "\u{1F3F3}\uFE0F\u200D\u26A7\uFE0F"
Conversation
|
rustbot has assigned @Mark-Simulacrum. Use |
|
Congratulations! I think you should also remove the entry with your deadname, if I understand the mailmap format correctly |
|
Reminder, once the PR becomes ready for a review, use |
|
awesome 🏳️⚧️ ❤️! but also, uhhhh, i think you're gonna need to rename that branch or bad things will happen. only-emoji branchnames have fucked up github in the past and created prs that were cursed and couldn't be merged. emojis are fine, just only emojis is not |
|
also remember to change your rust-lang/team entry: https://github.com/rust-lang/team/blob/f2d52d21a4d1f2d7321634454ce65c8d203e30f1/people/CAD97.toml |
Just goes to show how much that isn't my name anymore that I didn't even notice it while finding the alphabetical position for "Crystal" just eight lines lower. Thanks for catching that.
New PR it is then, GitHub doesn't allow changing the branch source of a PR as far as I'm aware. And it's hard to check it out locally, even, entering
Always something to miss. PR sent. rust-lang/team#2065 |
🏳️⚧️