Rename downcast_[ref|mut]_unchecked -> downcast_unchecked_[ref|mut]
#148079
+19
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer |
rustbot
added
the
S-waiting-on-review
rustbot
added
T-compiler
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
Author
|
Kept these names consistent in |
Member
|
Please squash, since revert commits defeat the purpose of submitting changes upstream. |
Undo rust-analyzer changes
Author
Done! Thanks @lnicola 🙏 |
Member
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 9, 2025
Rename `downcast_[ref|mut]_unchecked` -> `downcast_unchecked_[ref|mut]` ## Intent Renames `downcast_[ref|mut]_unchecked` to `downcast_unchecked_[ref|mut]` because we want to emphasise that it is the downcast that is unsafe, not the aliasing per: rust-lang#90850 (comment) ## Tracking Issue: rust-lang#90850 (comment) cc `@marc0246`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Renames
downcast_[ref|mut]_uncheckedtodowncast_unchecked_[ref|mut]because we want to emphasise that it is the downcast that is unsafe, not the aliasing per:#90850 (comment)
Tracking Issue: #90850 (comment)
cc @marc0246