-
Notifications
You must be signed in to change notification settings - Fork 14k
ci: Switch back to default coreutils (uutils) after libffi-sys bump #147798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
r? @marcoieni rustbot has assigned @marcoieni. Use |
|
@bors try jobs=aarch64-gnu,aarch64-gnu-debug,aarch64-gnu-llvm-20-1,aarch64-gnu-llvm-20-2 |
This comment has been minimized.
This comment has been minimized.
ci: Switch back to default coreutils (uutils) after libffi-sys bump try-job: aarch64-gnu try-job: aarch64-gnu-debug try-job: aarch64-gnu-llvm-20-1 try-job: aarch64-gnu-llvm-20-2
|
r? jieyouxu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@bors r+ rollup=never |
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 9606412 (parent) -> 843f8ce (this PR) Test differencesShow 2 test diffs2 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 843f8ce2ebc01d35a30484eadc8a84cdc6130844 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (843f8ce): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (secondary 0.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 473.265s -> 483.325s (2.13%) |
ci: Switch back to default coreutils (uutils) after libffi-sys bump Now that Miri has updated to the latest `libffi-sys`, we should be able to remove the GNU coreutils workaround, and switch back to the default coreutils (uutils) in the runners using Ubuntu 25.10 images. If we encounter any other uutils compatibility problems in the future, they should hopefully be easier to trace back to specific changes. - rust-lang#147581 - rust-lang/miri#4634 - rust-lang#147744 Closes rust-lang#147556.
Now that Miri has updated to the latest
libffi-sys, we should be able to remove the GNU coreutils workaround, and switch back to the default coreutils (uutils) in the runners using Ubuntu 25.10 images.If we encounter any other uutils compatibility problems in the future, they should hopefully be easier to trace back to specific changes.
Closes #147556.