-
Notifications
You must be signed in to change notification settings - Fork 14k
Implement Receiver for Exclusive
#146009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Receiver for Exclusive
#146009
Conversation
In the hope of being able to implement `DerefMut` in the future. Changes `Exclusive`'s methods to associated functions.
library/core/src/sync/exclusive.rs
Outdated
| } | ||
| } | ||
|
|
||
| // FIXME: implement `DerefMut` when this becomes possible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It isn't immediately obvious how/why this is blocked and what would make it possible, could you link to your comment explaining it on the tracking issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
Nominated for libs-api #98407 (comment) |
|
☔ The latest upstream changes (presumably #147128) made this pull request unmergeable. Please resolve the merge conflicts. |
|
We talked about this again in today's @rust-lang/libs-api meeting. It doesn't seem like trying to work towards If in the future we want to make this work with arbitrary self types, or if the idea of doing Is there another reason to add this in advance, given that it's an unstable trait being implemented for an unstable type? |
In the hope of being able to implement
DerefMutin the future.Changes
Exclusive's methods to associated functions.cc #98407
@rustbot label T-libs-api