Migrate rustc_middle diagnostic
#101021
Merged
Migrate rustc_middle diagnostic
#101021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-translation
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jackh726 (or someone else) soon. Please see the contribution instructions for more information. |
Collaborator
|
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
MingyuChen1
force-pushed
the
diagnostic
branch
from
ec88d70 to
8e5ed56
Compare
This comment has been minimized.
This comment has been minimized.
MingyuChen1
force-pushed
the
diagnostic
branch
from
8e5ed56 to
b9c60c6
Compare
This comment has been minimized.
This comment has been minimized.
MingyuChen1
force-pushed
the
diagnostic
branch
from
b9c60c6 to
9d0c521
Compare
This comment has been minimized.
This comment has been minimized.
MingyuChen1
force-pushed
the
diagnostic
branch
from
9d0c521 to
e1f36e1
Compare
Member
|
r? @davidtwco |
This comment has been minimized.
This comment has been minimized.
MingyuChen1
force-pushed
the
diagnostic
branch
from
05ff432 to
63ce44d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
MingyuChen1
force-pushed
the
diagnostic
branch
from
428e11e to
b37e645
Compare
davidtwco
reviewed
Sep 2, 2022
Member
davidtwco
left a comment
davidtwco
left a comment
There was a problem hiding this comment.
Thanks for working on this, I've left one comment with what you've got so far, I assume you're still working your way through the crate and not looking to merge yet?
davidtwco
approved these changes
Sep 6, 2022
Member
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 6, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#100658 (TyCtxt::get_attr should check that no duplicates are allowed) - rust-lang#101021 (Migrate ``rustc_middle`` diagnostic) - rust-lang#101287 (Document eager evaluation of `bool::then_some` argument) - rust-lang#101412 (Some more cleanup in `core`) - rust-lang#101427 (Fix ICE, generalize 'move generics to trait' suggestion for >0 non-rcvr arguments) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #100717