Skip to content

Clarify team repo approval requirements #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Clarify team repo approval requirements #971

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/infra/team-maintenance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ The following changes must be approved and merged by a `team-repo-admin`:
added, the team-repo-admins are expected to exercise their understanding of
which team owns the repository, when in doubt asking for clarification and
codifying in a comment in the relevant repository.
* Changing `bors.rust.review` permissions
* Changing `perf` permissions
* Changing `crater` permissions

On the other hand, changes to the configuration or automation of repositories
may be approved and merged by `infra-admins`:
Expand All @@ -51,6 +54,10 @@ may be approved and merged by `infra-admins`:
* This includes granting bots access to the repository.
* Changing the [repository branch protections](https://github.com/rust-lang/team/blob/master/docs/toml-schema.md#repository-branch-protections)

Granting a team write access to `rust-lang/rust` requires approval from both an
`infra-admin` and a `team-repo-admin` as that repository is particularly
sensitive.

### Source code changes

The team repository additionally contains code to transform and validate the
Expand Down