Fix to_string_in_format_args false positive
#9259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
llogiq
approved these changes
Jul 29, 2022
Contributor
llogiq
left a comment
llogiq
left a comment
There was a problem hiding this comment.
Just one small nit pick, otherwise this looks good.
clippy_lints/src/format_args.rs
Outdated
| } else { | ||
| "&" | ||
| }; | ||
| if n_needed_derefs == 0 && needed_ref.is_empty() { |
Contributor
There was a problem hiding this comment.
How about a needs_ref instead of a needed_ref so we don't need an is_empty() here?
Contributor
Author
|
Hopefully, I understood correctly. Thanks for reviewing, @llogiq. |
Contributor
|
☔ The latest upstream changes (presumably #9349) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
|
Yes, that's what I meant. Sorry for being absent for a while. r=me after rebase. |
Contributor
Author
|
Rebase done. Thanks again, @llogiq. |
Contributor
|
Thank you! @bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9256
changelog: none